[#58865] add enterprise banner to new custom field form #17173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://community.openproject.org/work_packages/58865 - show banner below form field selection, if - hierarchy is selected AND - enterprise token is not active - disable submit button, if the enterprise banner is shown
Kharonus
force-pushed
the
feature/58865-add-enterprise-gateway-to-creation-of-custom-fields-of-type-hierarchy
branch
from
fde6441
to
d27a077
Compare
- exclude hierarchies from anything but work packages
dominic-braeunlein
requested changes
Nov 13, 2024
| inputs: { | ||
| collapsible: true, | ||
| opReferrer: "custom-field-hierarchy", | ||
| textMessage: "PLACEHOLDER - upgrade to Starkiller Base", |
There was a problem hiding this comment.
Hi @Kharonus, here is still a placeholder UI copy in the PR.
There was a problem hiding this comment.
Yes, there is a TASK for Maya, to provide the correct text.
My take was, as this is behind a feature flag, we can merge it even with the placeholder. But before removing the flag, we need to replace it.
apfohl
approved these changes
Nov 13, 2024
Kharonus
deleted the
feature/58865-add-enterprise-gateway-to-creation-of-custom-fields-of-type-hierarchy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#58865
What are you trying to accomplish?
What approach did you choose and why?